Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/arcsine/kurtosis #3388

Merged
merged 12 commits into from
Dec 14, 2024

Conversation

aayush0325
Copy link
Contributor

@aayush0325 aayush0325 commented Dec 10, 2024

Resolves #3385

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/arcsine/kurtosis along with relevant tests, benchmarks, docs and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 10, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 10, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/arcsine/kurtosis $\color{green}186/186$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}186/186$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@aayush0325
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 10, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 10, 2024
@aayush0325
Copy link
Contributor Author

greetings! please give this a review @Planeshifter

@aayush0325
Copy link
Contributor Author

There was a missing benchmark.native.js file here, my apologies, pushed it now.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 12, 2024
@aayush0325 aayush0325 changed the title feat: add C implementation for @stdlib/stats/base/dists/arcsine/kurtosis feat: add C implementation for stats/base/dists/arcsine/kurtosis Dec 12, 2024
@Planeshifter Planeshifter self-requested a review December 14, 2024 03:32
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 14, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @aayush0325!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 14, 2024
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/arcsine/kurtosis`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3388
Closes: https://github.com/stdlib-js/stdlib/issues/3385

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: aayush0325 <aayush25khanna@gmail,com>
Co-authored-by: aayush0325 <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 31faa3e into stdlib-js:develop Dec 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/arcsine/kurtosis
4 participants