Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/dsnannsumors #2804

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

GittyHarsha
Copy link
Contributor

Resolves #1491

Description

What is the purpose of this pull request?

This pull request:

  • Refactors blas/ext/base/dsnannsumors to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 17, 2024
@GittyHarsha GittyHarsha changed the title refactor: update blas/ext/base/dsnannsumors to follow current project conventions refactor: update blas/ext/base/dsnannsumors Aug 18, 2024
@GittyHarsha GittyHarsha marked this pull request as ready for review August 18, 2024 11:04
@GittyHarsha
Copy link
Contributor Author

@Planeshifter, please review my PR.
Thanks!

@GittyHarsha
Copy link
Contributor Author

Any updates?

@Planeshifter Planeshifter self-requested a review August 24, 2024 14:23
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Aug 24, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @GittyHarsha!

PR looked very good; I just reverted the changes to the copyright years, which we do not update when files are edited.

…t/test.dsnannsumors.native.js

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Sep 2, 2024
@GittyHarsha
Copy link
Contributor Author

Thank you for your contribution @GittyHarsha!

PR looked very good; I just reverted the changes to the copyright years, which we do not update when files are edited.

Thanks! I hope this will be my first contribution.

@Planeshifter Planeshifter merged commit 7cc8bb9 into stdlib-js:develop Sep 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dsnannsumors to follow current project conventions
3 participants