Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dnannsumpw to follow current project conventions #2180

Merged
merged 16 commits into from
Apr 20, 2024
Merged

refactor: update blas/ext/base/dnannsumpw to follow current project conventions #2180

merged 16 commits into from
Apr 20, 2024

Conversation

naveen1m
Copy link
Contributor

Resolves #1482

Description

What is the purpose of this pull request?

This pull request:

  • Refactors @stdlib/blas/ext/base/dnannsumpw to follow current project conventions.

Checklist

  • update README.md
  • manifest.json
  • include.gypi
  • benchmark
  • examples
  • docs
  • test
  • src
  • lib

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Apr 17, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Apr 17, 2024
@Planeshifter Planeshifter self-requested a review April 17, 2024 02:16
@naveen1m
Copy link
Contributor Author

@Planeshifter all test passed, please review!

@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Apr 20, 2024
Planeshifter
Planeshifter approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @naveen1m!

@Planeshifter Planeshifter merged commit 430a72b into stdlib-js:develop Apr 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnannsumpw to follow current project conventions
3 participants
@naveen1m @Planeshifter @stdlib-bot