Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dfill to follow current project conventions #1455

Merged
merged 8 commits into from
Mar 3, 2024
Merged

refactor: update blas/ext/base/dfill to follow current project conventions #1455

merged 8 commits into from
Mar 3, 2024

Conversation

Snehil-Shah
Copy link
Member

@Snehil-Shah Snehil-Shah commented Mar 2, 2024 •
edited
Loading

Resolves #1434

Description

What is the purpose of this pull request?

This pull request:

  • Refactors blas/ext/base/dfill to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
Copy link
Member Author

@kgryte should I also update the license year or do they represent the year of first publication?

@kgryte
Copy link
Member

kgryte commented Mar 2, 2024

Only in new files. No need to update the license year for existing files.

@kgryte kgryte changed the title chore: refactor blas/ext/base/dfill to follow current project conventions refactor: update blas/ext/base/dfill to follow current project conventions Mar 3, 2024
@kgryte kgryte added the Needs Review A pull request which needs code review. label Mar 3, 2024
kgryte
kgryte requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Snehil-Shah. My only remaining comment is updating the indentation in the manifest.json file. Once resolved, this should be ready for merge.

@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 3, 2024
@Snehil-Shah Snehil-Shah requested a review from kgryte March 3, 2024 14:39
kgryte
kgryte approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 3, 2024
@kgryte kgryte merged commit 2675d58 into stdlib-js:develop Mar 3, 2024
7 checks passed
@AuenKr AuenKr mentioned this pull request Mar 6, 2024
Closed
3 tasks
PoookieCoder pushed a commit to PoookieCoder/stdlib that referenced this pull request Mar 7, 2024
@Snehil-Shah @kgryte
refactor: update blas/ext/base/dfill to follow current project conv…
ad90536 
…entions

Closes: stdlib-js#1434
Ref: stdlib-js#1152
PR-URL: 	stdlib-js#1455
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Mar 13, 2024
@Snehil-Shah Snehil-Shah mentioned this pull request Mar 29, 2024
Closed
6 tasks
@Snehil-Shah Snehil-Shah deleted the issue1434-refactor branch April 26, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dfill to follow current project conventions
2 participants
@Snehil-Shah @kgryte