Add request client #342
Merged
Add request client #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicio
commented
Feb 10, 2023
felicio
commented
Feb 10, 2023
packages/status-js/src/preview-client/map-community-chat-preview.ts
Outdated
Show resolved
Hide resolved
| return | ||
| } | ||
|
|
||
| // todo!: report js-waku abort logic |
There was a problem hiding this comment.
Since js-waku calls the callback per message concurrently, abort = true from one call most likely won't stop the others.
There was a problem hiding this comment.
Consider using queryGenerator instead in the future.
Merged
felicio
commented
Mar 2, 2023
felicio
added a commit
to felicio/status-web
that referenced
this pull request
May 15, 2023
* add `preview-client.ts` * add exports * fix imports * set emoji hash * use `message.timestamp` * rename `RequestClient` * drop preview keyword * rm `appUrl` * rm todo?: * remove social urls * remove if clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.