Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to consistent shorthand hash syntax #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jandudulski
Copy link
Contributor

@jandudulski jandudulski commented Oct 6, 2022

The only thing that I don't like more than a shorthand hash syntax is mixed syntax. When standard was introducing EnforcedShorthandSyntax: either a consistent option didn't exist yet (actually either didn't exist too, it was introduced thanks to standard ❤️ ) but now it should be no brainer to switch to this one.

# with either

# good
{foo: foo, bar: bar}

# good
{foo:, bar: bar} # !!!

# good
{foo:, bar:}
# with consistent

# bad
{foo: , bar: bar}

# good
{foo:, bar:}

# bad
{foo: , bar: baz}

# good
{foo: foo, bar: baz}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant