Working solution for adding rows and columns at the expected location

[bryvin]

This is source code only, had issues with the package.json and conflicting versions of node modules from when this was last published (and not having them installed).

In reference to: standardnotes/forum#474

[moughxyz]

Oo, nice. What do you mean by source code only? Also, if you haven't already, can you test this using the "Crypto asset summary" demo sheet at standardnotes.org/demo? Just want to make sure it's tested with a sufficiently complex worksheet which relies on cell calculations, etc.

[bryvin]

** Removed content..

I just re-read my post and noticed it did actually break the calculations. RIP... That may actually be tricky to do this then lol..

I'll have to find some more time to go over why it wasn't working with the original version cause it does work in their demos.

[moughxyz]

Ah damn, close one. I figured the calculations would make this difficult. I am curious too why it works in theirs and not ours, and what the original reason for the custom handling on our part was 🤔

[bryvin]

I updated my pull request to have an actual working solution. Again it's only the 1 source file and not the compiled dist due to the npm modules.

I hijacked the render method to make this work. It wasn't working previously because in the event you had handled you were taking the JSON and then using that data to re-save it at the end of the same function. The data however included the old indexes and information, just with updated row/column count. Essentially it was overwriting the legit changes KendoUI was doing with the old data and 1 more row/column.

[moughxyz]

Very nice, I'll test this out sometime in the next few days.

[moughxyz]

Need a little more time on this, sorry. Should have known better than to say next few days..

[bryvin]

No worries, take your time. 👍

[moughxyz]

I'm seeing a strange issue with this:

1. Start a new sheet and type "Foo" in A1 and "Bar" in B1.
2. Go to the last row, 75, and insert a row below or above.
3. Any content in row 1 after A1 is deleted. In this case, "Bar" is deleted. If you had content in C1 and D1, it also would be deleted.

This issue does not happen in the production version. But besides that, the new functionality is very nice to have and works as you'd expect.

[twoprops]

Hi! The ability to add and delete rows and columns appears to still be broken in the current version (1.3.3) six months after the last comment. As this is core functionality for any spreadsheet (since, oh, VisiCALC) I feel that it is disrespectful to users to list this with other editors and extensions that actually work. SN users are likely to install the editor and put significant effort into making it work, only to discover that critical core functionality is broken. I suggest amending the editor description within SN to warn users that this is not currently a fully functioning editor.