Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch last space in regex in expose_stan_functions #1115

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Feb 8, 2024

Summary:

Fixes #1114 by catching the last space in the regex for expose_stan_functions, which can be a line break.
Previous PRs #1094 and #1099 did not completely fix this problem. Scanning the culpable line this should be the last one to fix.

Intended Effect:

Example in Issue #1114 works.

How to Verify:

Text example in Issue #1114

Side Effects:

None

Documentation:

n/a

Reviewer Suggestions:

@andrjohns (sorry, once more)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian funk

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Contributor

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@andrjohns andrjohns merged commit 50c3c6f into stan-dev:develop Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose_stan_functions still sometimes fails with ..._lp functions
2 participants