Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LdFlags for new RcppParallel #1108

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix LdFlags for new RcppParallel #1108

merged 1 commit into from
Jan 11, 2024

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jan 11, 2024

Summary:

This copies a small tweak from RcppParallel to support cross compiling, see: RcppCore/RcppParallel#208

Basically we check $TBB_LINK_LIB before checking $TBB_LIB which is needed when the runtime arch (TBB_LIB) is different from the one we are compiling for (TBB_LINK_LIB)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Jeroen Ooms

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Contributor

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge once CI passes

@andrjohns
Copy link
Contributor

Failures are unrelated to these changes, thanks again!

@andrjohns andrjohns merged commit 7f91960 into stan-dev:develop Jan 11, 2024
1 of 7 checks passed
@andrjohns
Copy link
Contributor

@bgoodri can you push your CRAN changes to the repo? That will resolve the current CI failures

@bgoodri
Copy link
Contributor

bgoodri commented Jan 11, 2024

Yes

@andrjohns
Copy link
Contributor

@bgoodri quick reminder to please push your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants