Refactor preferences page to using a navigation sidebar, rearrange preference items #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are the preference items in each page: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more and more preference items. Before this change, we have to scroll down to find the preference item we want. After this changes, the preferences page uses a sidebar for navigation, like how windows settings app does.
Preferences items are also rearranged. The main change is that two new categories, "UTAU" and "DiffSinger" are created for renderer-specified preference items, because some users only use UTAU voicebank or only use DiffSinger voicebanks. Having "UTAU" and "DiffSinger" will make these preference items easier to find.
