Add DAW Integration #1266
Add DAW Integration #1266
Conversation
There was a problem hiding this comment.
It's almost done!
Test build is available on: https://github.com/sevenc-nanashi/OpenUtau/releases/tag/0.1.530-dev.0
I used Visual Studio's formatter for my C# code, and clang-format for C++ files.
Is there existing configuration for formatters?
| Notes: | ||
| - `-DCMAKE_BUILD_TYPE=Debug` can be replaced with `-DCMAKE_BUILD_TYPE=Release` for a release build. | ||
| - When you're using Visual Studio, your plugin will be built in `build/x64-Debug` or `build/x64-Release` instead. | ||
| - This plugin is very unstable! Don't forget to save your work often. |
There was a problem hiding this comment.
- Debugging: I'm sure that there is a bug that causes DAW to crash.
DawPlugin/src/DistrhoPluginInfo.h
Outdated
| #define DISTRHO_PLUGIN_WANT_FULL_STATE 1 | ||
| #define DISTRHO_UI_DEFAULT_WIDTH 1024 | ||
| #define DISTRHO_UI_DEFAULT_HEIGHT 256 | ||
| #define DISTRHO_UI_FILE_BROWSER 1 |
There was a problem hiding this comment.
- A button to download internal ustx file:
For an escape hatch.
| await UpdateUstx(); | ||
| await UpdateTracks(); | ||
| }); | ||
| sendAudioDebounce.Do(TimeSpan.FromSeconds(5), async () => { |
There was a problem hiding this comment.
- The interval:
I thought that creating hash for every audio causes high CPU usage, so I debounced to 5 seconds.
Should this be configurable?
| /// OpenUtau to DAW notification. | ||
| /// Does not require a response. | ||
| /// </summary> | ||
| public abstract class DawDawNotification : DawMessage { |
There was a problem hiding this comment.
- Naming:
I'm pretty sure that there is better naming than this
| @@ -241,7 +242,8 @@ public void OnNext(UCommand cmd, bool isUndo) { | |||
| DocManager.Inst.ExecuteCmd(new SetPlayPosTickNotification(0)); | |||
| } | |||
| if (cmd is PreRenderNotification || cmd is LoadProjectNotification) { | |||
| if (Util.Preferences.Default.PreRender) { | |||
| // Always prerender when it's connected to daw | |||
There was a problem hiding this comment.
- Is using prerendering ok?:
The daw integration uses pre-render audios, but I don't know if there is something that prerender misses.
| @@ -546,6 +548,18 @@ General | |||
| <system:String x:Key="tracks.trackcolor">Change track color</system:String> | |||
| <system:String x:Key="tracks.tracksettings">Track Settings</system:String> | |||
|
|
|||
| <system:String x:Key="dawintegrationterminal.captions">Connect to DAW</system:String> | |||
| <system:String x:Key="dawintegrationterminal.description">Download Plugin, show UI and connect (temporary text)</system:String> | |||
There was a problem hiding this comment.
- Description:
I don't have a good word that explains about connecting.
|
|
||
| void OnDownloadClick(object sender, RoutedEventArgs args) { | ||
| try { | ||
| OS.OpenWeb("https://example.com"); |
There was a problem hiding this comment.
- Downloads:
Where should the "download" button link to? A release page?
This PR adds DAW Integration, in other words, VST integration.
I created a thread for this in discord: https://canary.discord.com/channels/551606189386104834/1279749765092872293