Forward all known GitHub headers #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnieto
force-pushed
the
fix/header-forwarding
branch
from
041353e to
6d8214f
Compare
Previous to this changes, only the relevant headers for the hook were forwarded. Right now, we are keeping all of them and then we are checking that, required headers, are present. This should prevent removing the github signature when the proxy does not validate the request signature.
gnieto
force-pushed
the
fix/header-forwarding
branch
from
6d8214f to
f959e79
Compare
maxisam
added a commit
to maxisam/GitWebhookProxy
that referenced
this pull request
Jan 5, 2023
maxisam
added a commit
to maxisam/GitWebhookProxy
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this changes, only the relevant headers for the hook were
forwarded. Right now, we are keeping all of them and then we are
checking that, required headers, are present.
This should prevent removing the github signature when the proxy does
not validate the request signature.
Fixes: #94