Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mutation testing #8

Merged
merged 32 commits into from
Jan 16, 2024
Merged

Feat/mutation testing #8

merged 32 commits into from
Jan 16, 2024

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Jan 11, 2024

feature: mutation testing functional for PR differences in composite actions

ASuciuX and others added 28 commits December 11, 2023 01:14
needs initial output pushed into this branch before merging
- Updated message for unviable mutants, steps to solve it
Based on the type of package it will include the corresponding arguments to be run with.

Cases:
- if >= 16 mutants on big packages => run big packages using 8 shards
- else run big packages without shards

- if >= 16 mutants on big packages and >= 120 mutants on small packages => run small packages using 4 shards
- else if < 16 mutants on big packages and >= 80 mutants on small packages => run small packages using 4 shards
- else run small packages without shards
Move Shells from Main Workflow to Composite Action
@ASuciuX ASuciuX requested a review from wileyj January 11, 2024 20:27
mutation-testing/README.md Outdated Show resolved Hide resolved
@wileyj
Copy link
Collaborator

wileyj commented Jan 12, 2024

one question i have here - is this workflow meant to run from any rust- based project, or only the stacks-core repo?
if it's only meant to run against stacks-core, i would advocate moving all the files under stacks-core (./stacks-core folder in the repo root).

functionally it looks good - just minor changes to align with standards from other workflows in this repo

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Jan 14, 2024

I've done the modifications on my repo (https://github.com/ASuciuX/actions/tree/test/move-shell-to-composite) in case there were more commits with fixes if the workflow fails. I've also removed the shell-scripts folder because the script was only called in one place, and with this, i've also removed the cloning of the actions repository in the composite.

one question i have here - is this workflow meant to run from any rust- based project, or only the stacks-core repo? if it's only meant to run against stacks-core, i would advocate moving all the files under stacks-core (./stacks-core folder in the repo root).

functionally it looks good - just minor changes to align with standards from other workflows in this repo

It was initially meant to only run on the stacks-core repo, but with the way it's structured right now, it can be run on any rust project. However, since only stackslib and stacks-node packages are considered big, it will run all the mutants as small - without --test-threads 1 argument or BITCOIND_TEST=1 and RUST_BACKTRACE=full env vars.

- update readme files
- check exit codes
- check that files exist before accessing them, otherwise exit
- remove shell scripts folder since it was only used in 1 place
- update actions versions used
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj merged commit a5a99fc into main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants