Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass authorization header only if specified #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: pass authorization header only if specified #16

wants to merge 2 commits into from

Conversation

DerekTBrown
Copy link

  • Act is a project which allows users to locally test GitHub actions before deploying them. This makes it easier for users to validate that actions work as intended.
  • Currently, running kube-linter-action locally results in a 401 error when trying to fetch the release because we pass an empty authorization header.
  • This PR fixes this by conditionally passing this header.

@DerekTBrown DerekTBrown changed the title fix: pass authentication header only if specified fix: pass authorization header only if specified Jun 23, 2022
janisz
janisz requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better late than never ;)

action.yml Outdated Show resolved Hide resolved
@DerekTBrown @janisz
Update action.yml
82a50db 
Co-authored-by: Tomasz Janiszewski <[email protected]>
@DerekTBrown DerekTBrown requested a review from janisz March 6, 2024 19:37
janisz
janisz requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, something is wrong with var substitution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerekTBrown @janisz