Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly package repo syncs #325

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Fix nightly package repo syncs #325

merged 9 commits into from
Sep 9, 2024

Conversation

Alex-Welsh
Copy link
Contributor

Added a new variable, sync_group, to the repo definitions. Repos with the same sync group will be synced at the same time.
Generally easier to create custom groups than trying to regex match against names
Regex filters should still work when running the workflow manually

Bumped the overall time limit and per-retry time limit as Rocky 9 BaseOS has started taking >6h to sync on its own

Test workflow is running here

Some individual repos have started taking >6h to sync. This Commit bumps
the timeout so they don't expire.
@Alex-Welsh Alex-Welsh requested a review from a team as a code owner September 2, 2024 13:19
@Alex-Welsh Alex-Welsh marked this pull request as draft September 2, 2024 14:10
@Alex-Welsh
Copy link
Contributor Author

Just noticed this doesn't work for Ubuntu yet 🤦 setting to draft for now

@Alex-Welsh Alex-Welsh marked this pull request as ready for review September 2, 2024 15:07
@Alex-Welsh
Copy link
Contributor Author

Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the approach.

.github/workflows/package-sync.yml Show resolved Hide resolved
.github/workflows/package-sync-nightly.yml Outdated Show resolved Hide resolved
.github/workflows/package-sync-nightly.yml Outdated Show resolved Hide resolved
ansible/validate-deb-repos.yml Outdated Show resolved Hide resolved
Added new tests to check sync groups are defined for all synced repos
Updated sync group on various repos
Increasing the timeout did not help syncs
This reverts commit 7f4ebcf.
@Alex-Welsh Alex-Welsh force-pushed the fix-nightly branch 2 times, most recently from 2dc8367 to 4f6e434 Compare September 6, 2024 08:25
@Alex-Welsh
Copy link
Contributor Author

Retest here

markgoddard
markgoddard previously approved these changes Sep 6, 2024
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass.

@Alex-Welsh
Copy link
Contributor Author

Missed a fix for the Ubuntu mirrors, test here

@markgoddard markgoddard merged commit f53a8f2 into main Sep 9, 2024
3 checks passed
@markgoddard markgoddard deleted the fix-nightly branch September 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants