Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terraform-kayobe-multinode repo #274

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

markgoddard
Copy link

  • Add terraform-kayobe-multinode to Kayobe team
  • Move bifrost from OpenStack to Kayobe team
  • Template account and repo in GitHub runner deployment

@markgoddard markgoddard requested a review from a team as a code owner December 20, 2023 09:06
@markgoddard markgoddard self-assigned this Dec 20, 2023
Using prevent_destroy prevents moving repositories between teams.
Although branch protections are sensitive, we won't lose any data by
simply removing them.
@stackhpc-ci
Copy link
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @markgoddard, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@Alex-Welsh
Copy link
Contributor

https://github.com/stackhpc/stackhpc-release-train/actions/runs/7273356680/job/19817160390?pr=274#step:7:986
We don't currently version the terraform-kayobe-multinode repo with stackhpc/* branches so the branch protection won't have any effect. I'd probably vote for starting versioned branches rather than updating the rules though.

@markgoddard
Copy link
Author

https://github.com/stackhpc/stackhpc-release-train/actions/runs/7273356680/job/19817160390?pr=274#step:7:986 We don't currently version the terraform-kayobe-multinode repo with stackhpc/* branches so the branch protection won't have any effect. I'd probably vote for starting versioned branches rather than updating the rules though.

Good catch. I'm not sure we want to get into versioned branches there though. Probably we need to change the fomat of the input data to be more flexible, but I think I'll leave this for now.

@markgoddard markgoddard marked this pull request as draft December 20, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants