Promote multiple tags simultaneously based on Kayobe config #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
force-pushed
the
container-promote-mk3
branch
5 times, most recently
from
d327c0f
to
6e255b0
Compare
markgoddard
force-pushed
the
container-promote-mk3
branch
3 times, most recently
from
5afe4b1
to
61bbe28
Compare
Alex-Welsh
reviewed
Oct 25, 2023
Alex-Welsh
reviewed
Oct 25, 2023
jackhodgkiss
reviewed
Jan 5, 2024
This modifies the container image promotion process to be similar to package repo promotion. The tags for each image are stored in files in StackHPC Kayobe configuration (one per base distro), and these are queried to determine which tag to promote for each image. This avoids the need to specify tags when promoting images, and will allow for automatic tag promotion after merges to StackHPC Kayobe Configuration.
markgoddard
force-pushed
the
container-promote-mk3
branch
from
f7a9c7b
to
849ad76
Compare
priteau
requested changes
Jan 29, 2024
It will only go stale.
priteau
reviewed
Jan 29, 2024
We no longer use virtualenvs in CI.
jovial
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the container image promotion process to be similar to package repo promotion. The tags for each image are stored in a file in StackHPC Kayobe configuration (the kolla_image_tags variable), and these are queried to determine which tag to promote for each image.
This avoids the need to specify tags when promoting images, and will allow for automatic tag promotion after merges to StackHPC Kayobe Configuration.
This new process works on Zed and later releases. The existing workflow and playbook are renamed with an "old" suffix since these are still required for Yoga and earlier releases.
Needed by stackhpc/stackhpc-kayobe-config#663