Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opensearch grafana plugin config #555

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Opensearch grafana plugin config #555

merged 2 commits into from
Jun 28, 2024

Conversation

technowhizz
Copy link

Changes needed to configure the opensearch plugin in grafana when first configuring it. As mentioned in the release note:

 To apply this you need to delete the datasource and reconfigure grafana.

@technowhizz
Update Grafana OpenSearch datasource configuration
51674da 
Updates the Grafana OpenSearch datasource configuration to use values
for OpenSearch that work out of the box.

Closes-Bug: #2039500
Change-Id: Id9c7e59e6ae1dd98176c68b14a2aff1985306751
@technowhizz
Configure log level field for the Grafana OpenSearch datasource
b143dda 
Change-Id: Ic38469661323fbce438c70bd1b9301e9f7db8030
@technowhizz technowhizz requested a review from a team as a code owner April 18, 2024 21:47
@technowhizz technowhizz self-assigned this Apr 19, 2024
dougszumski
dougszumski approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@dougszumski dougszumski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is low risk since KA won't change the existing plugin config and the current config is wrong in any case. We have the data source installed here:

stackhpc/kolla@9ee9677

@dougszumski
Copy link
Member

Before merging, we should make sure that the OpenSearch datasource is in the latest release train Grafana image.

@dougszumski
Copy link
Member

it is but if anyone rebuild grafana from the main kolla branch then we will lose it so lets wait for that to merge too

Should be fine I think: https://review.opendev.org/q/Ia3a39c975abf815a66765f2f98c4789d6cec33d7

@technowhizz technowhizz mentioned this pull request Jun 28, 2024
Merged
@technowhizz technowhizz merged commit d1335a5 into stackhpc/2023.1 Jun 28, 2024
3 checks passed
@technowhizz technowhizz deleted the opensearch-grafana-plugin-config branch June 28, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard left review comments

@dougszumski dougszumski dougszumski approved these changes

Assignees

@technowhizz technowhizz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@technowhizz @dougszumski @markgoddard