Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable allowUnfree for Terraform versions >= 1.6 #72

Merged
merged 30 commits into from
May 9, 2024

Conversation

sestrella
Copy link
Member

@sestrella sestrella commented Apr 23, 2024

Related with #71

TODO

  • Add breaking change note to commit message
  • Update the configuration input once it gets merged into main

@sestrella sestrella changed the title PoC: Avoid --impure flag workaround feat: Enable allowUnfree for Terraform versions >= 1.6 Apr 26, 2024
@sestrella sestrella marked this pull request as ready for review April 26, 2024 19:42
@oscar-izval
Copy link
Contributor

Hey @sestrella, this is looking great! I like it a lot. I wonder if we should create a ./template/config instead of using ./config as the template. That way we could also provide a full example for those wanting to go that route (and possibly fix the current issue, because it's missing a devshell for that simple flake).

@sestrella
Copy link
Member Author

@oscar-izval I addressed your comment. Would you mind taking a second look? In terms of how to release this change, I believe we would need to merge it first with the config input pointing to this feature branch, and then once the config template is on main, we could update the input and flake.lock file before doing a new release. What do you think?

Copy link
Contributor

@oscar-izval oscar-izval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sestrella sestrella merged commit 4f09d5a into main May 9, 2024
8 checks passed
@sestrella sestrella deleted the poc_allow_unfree branch May 9, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants