Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test flake templates #5

Merged
merged 12 commits into from
Nov 17, 2023
Merged

Test flake templates #5

merged 12 commits into from
Nov 17, 2023

Conversation

sestrella
Copy link
Member

@sestrella sestrella commented Nov 16, 2023 •
edited
Loading

TODO:

  • Add template references to README file

@sestrella sestrella marked this pull request as ready for review November 16, 2023 08:34
@sestrella sestrella marked this pull request as draft November 16, 2023 08:34
@sestrella sestrella marked this pull request as ready for review November 17, 2023 07:33
@sestrella
Copy link
Member Author

@oscar-izval would you mind taking a look at this PR, please?

oscar-izval
oscar-izval reviewed Nov 17, 2023
View reviewed changes
.github/workflows/ci.yml
- name: Install Nix
uses: DeterminateSystems/nix-installer-action@v6
- name: Replace inputs on templates
run: sed -i 's/github:stackbuilders\/nixpkgs-terraform/github:stackbuilders\/nixpkgs-terraform\/${{ github.sha }}/g' templates/*/flake.nix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

oscar-izval
oscar-izval approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@oscar-izval oscar-izval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@sestrella sestrella merged commit 91d51d8 into main Nov 17, 2023
3 checks passed
@sestrella sestrella deleted the test_templates branch November 17, 2023 11:13
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sestrella added a commit that referenced this pull request Nov 21, 2023
@sestrella
Test flake templates (#5)
80015d8 
* Test devenv template

* Minor changes to CI workflow

* Fix reference to terraform

* Minor change

* Add devenv template to flake.nix

* Accept flake config

* Add timeout to templates

* Update output reference devShell -> devShells

* Revert renaming devShells -> devShell

* Update README

* Make "Binary Cache" a subsection

* Add Templates section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscar-izval oscar-izval oscar-izval approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sestrella @oscar-izval