Support on sftp local changedir mimmicking #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some implementations of sftp servers where "ChangeDir" will cause the server to go to a different physical path (due to soft links on the server) where the permissions are different from those permissions if the client-perceived paths are used.
The current sftp client implementation makes use of GetCanonicalPath which causes for those servers to potentially cause a permissions error where the path provided by the client has the right permissions.
This change allows the sftpclient to be configured so the client will always use the paths provided by the application and will not try to changedirs on the server, thus avoiding this issue.
For reference, this problem is present in some Sftp implementation for certain Cisco routers, for example.