Add subnet mask of interface for the SGi connection #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @matan1008 . We'll review it shortly. |
frankist
approved these changes
Apr 22, 2021
|
Is there anything I can do to help with the PR? |
|
Could you please check if this PR is still relevant? Thanks |
|
Still relevant 😄 |
Thanks for the quick response. Do you mind rebasing PR on current master. |
matan1008
force-pushed
the
feature/configure-sgi-subnet
branch
from
8ae9bc7
to
d5a86d6
Compare
|
I think it's fine, but IP network programming is not my area of expertise so please review it carefully 🙇 |
matan1008
force-pushed
the
feature/configure-sgi-subnet
branch
from
d5a86d6
to
6200bdf
Compare
|
|
matan1008
force-pushed
the
feature/configure-sgi-subnet
branch
from
6200bdf
to
5170e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This change will allow allocating more than 254 addresses for UEs.
I am pretty terrified that I missed something, so I would like your close inspection and your professional opinion.
Thanks for dedicating time!