Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npmRegistry as first class citizen node config parameter #347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nowheresly
Copy link

I was struggling the whole day trying to configure a specific npm registry in my build file (written in kotlin DSL) by following the instruction of the FAQ (written in Groovy DSL).

At the end, I'm wondering if this setting could deserve to be an official setting for the gradle-node-plugin.

In this PR, i just added the variable npmRegistry and updated the documentation accordingly.

Now, specifying an npm registry is as simple as this:

node {
   npmRegistry = 'https://myregistry.npm.com'
}

Do you think this PR could make sense?
Thanks in advance for your time.

@savinov
Copy link

savinov commented Oct 27, 2019

@Nowheresly do you have a workaround to specify NPM registry URL while your PR is in progress?

@Nowheresly
Copy link
Author

@Nowheresly do you have a workaround to specify NPM registry URL while your PR is in progress?

Right now my workaround is to put in the buildSrc folder of my project the gradle-node-plugin with my PR. So I can easily specify my own npm registry. I could switch back to the official version of the plugin when my PR will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants