Store only one version of i18n strings #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPM files with multiple translated entries for strings would cause a crash when parsing, so packages with things like: Summary: One package Summary(pt_BR): Um pacote would invoke the extract_string function with a count > 1. Fully handling all of the i18n capabilities of RPM requires some re-work on the header handling, but for the sake of simplicity and to be able to parse those rpm files, all extra translated strings are discarded and only the first one is kept.
boiko
added a commit
to boiko/hackweek-applied-pase
that referenced
this pull request
Nov 8, 2023
Hopefully the upstream change will be accepted/reworked: srossross/rpmfile#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPM files with multiple translated entries for strings would cause a crash when parsing, so packages with things like:
Summary: One package
Summary(pt_BR): Um pacote
would invoke the extract_string function with a count > 1.
Fully handling all of the i18n capabilities of RPM requires some re-work on the header handling, but for the sake of simplicity and to be able to parse those rpm files, all extra translated strings are discarded and only the first one is kept.