-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve ambiguities based on closer common ancestor #498
Conversation
I was just looking into how it might be possible to add resolution (nearest ancestor), since I have same-name notes in different directories all over the place, making the current behavior a blocker for using emanote for my big repo. So great to see a patch in progress Srid! I would prefer that the behavior be to omit descendant search entirely, and search only ancestors (that's what Ikiwiki does), but I don't need that to get unblocked. I just did a test build and it's still showing ambiguous link errors for me: (out of scope here, the rendering for these inline errors has always seemed broken for me. Missing style or something?) LMK if you want review when you're ready. |
Previous discussion, starting at #115 (reply in thread) |
Without descendant search, it would not be possible to "combine" multiple sites though (see #494), and thus it would break https://community.flake.parts/ (the various docs come from different repos; and |
I was too ambigious with "... omit descendant search entirely". I meant a ref This would require all descending path elements to be explicit in refs. This would allow matching on subdirs for flexible reference remapping (eg, a local site registry mapping ref prefixes to URL prefixes for external sites). I'm only guessing at the use-case you're working on. Am I missing part of the requirement? |
@edrex What is the value of If Could you provide a more rigorous logic so I can understand what you are proposing? |
I'm gonna merge this now; but will always be happy to revisit the ambiguity resolution algorithm based on convincing rationale. |
[[foo]]
(if that foo was an ambiguity resolved)