Support dependency on taskProvider (among other things) #2946
+125
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
force-pushed
the
bquenaudon.2024-05-09.srcDirTaskProvider
branch
5 times, most recently
from
244173f
to
9beef31
Compare
oldergod
requested review from
martinbonnin,
staktrace,
Egorand,
JakeWharton and
swankjesse
and removed request for
staktrace
oldergod
changed the title
staktrace
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Seems reasonable enough. I'm concerned about the change in ABI, though. There could be gradle plugins that are compiled against the old version of wire (with srcDir(String)) which will break if used in a build with the new version of wire on the buildscript classpath. It might be better to lave srcDir alone and add a new function that takes Any so that there's no ABI breakage
|
I can keep srcDir(string) alongside it |
oldergod
force-pushed
the
bquenaudon.2024-05-09.srcDirTaskProvider
branch
from
9beef31
to
d3bef4d
Compare
JakeWharton
approved these changes
Jul 3, 2024
| /** Sets a directory. Example: "src/main/proto". */ | ||
| @Deprecated("Deprecated in favor of 'srcDir(fileCollection)'") |
There was a problem hiding this comment.
If you are deprecating this function, seems like the one below it should go as well.
martinbonnin
approved these changes
Jul 3, 2024
| @@ -291,11 +293,25 @@ open class WireExtension( | |||
| /** Calling this will resolve the configuration. */ | |||
| internal val roots: Set<File> | |||
| get() = configuration.files + sourceDirectoriesAndLocalJars | |||
| private val files: ConfigurableFileCollection by lazy(NONE) { | |||
| val files = project.files() | |||
| project.dependencies.add(configuration.name, files) | |||
There was a problem hiding this comment.
TIL you could pass a FileCollection as a dependency
oldergod
force-pushed
the
bquenaudon.2024-05-09.srcDirTaskProvider
branch
from
d3bef4d
to
e82f6bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2933