Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when 0 (Sunday) is used as WeekDayNumber in HolidaysDefinition.json #45

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix error when 0 (Sunday) is used as WeekDayNumber in HolidaysDefinition.json #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6cecee
Fix configuration error when WeekDayNumber is 0 (Sunday)
albertospelta Mar 26, 2024
3b136ea
Applied fix as suggested by the code review
albertospelta Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dax.Template/Tables/Dates/HolidaysTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public HolidaysTable(IHolidaysConfig config): base(config)
__SeptemberEquinox + '{config.HolidaysDefinitionTable}'[DayNumber],
IF ( '{config.HolidaysDefinitionTable}'[MonthNumber] = 96, -- March Equinox
__MarchEquinox + '{config.HolidaysDefinitionTable}'[DayNumber],
IF ( '{config.HolidaysDefinitionTable}'[WeekDayNumber] <> 0,
IF ( '{config.HolidaysDefinitionTable}'[WeekDayNumber] IN {{ 0, 1, 2, 3, 4, 5, 6 }},
VAR _ReferenceDate =
DATE ( __HolidayYear, 1
+ MOD ( '{config.HolidaysDefinitionTable}'[MonthNumber] - 1 + IF ( '{config.HolidaysDefinitionTable}'[OffsetWeek] < 0, 1 ), 12 ), 1 )
Expand Down
Loading