Fix JP/Greenery Day holiday definition #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2007, Greenery Day moved to May 4, and April 29 was changed to Shōwa Day in accordance with a 2005 revision of the law pertaining to public holidays. This fixes an issue where duplicate rows caused the `LOOKUPVALUE` function to fail with the error "A table of multiple values was supplied where a single value was expected" while retrieving the noliday name.
albertospelta
added a commit
to sql-bi/DaxTemplate
that referenced
this pull request
May 28, 2024
* Update HolidaysDefinition.json from sql-bi/Bravo#790
albertospelta
added a commit
to sql-bi/DaxTemplate
that referenced
this pull request
May 28, 2024
* Update HolidaysDefinition.json from sql-bi/Bravo#790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2007, Greenery Day moved to May 4, and April 29 was changed to Shōwa Day in accordance with a 2005 revision of the law pertaining to public holidays. This fixes an issue where duplicate rows caused the
LOOKUPVALUEfunction to fail with the error "A table of multiple values was supplied where a single value was expected" while retrieving the holiday name.