Weather API: sunrise & sunset timezone adjustment #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunrise & sunset times are provided in UTC, see: https://openweathermap.org/current#fields_json
crossplatformdev
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while using the StarField watchface that the sunrise & sunset times displayed didn't have their timezone adjusted.
As per https://openweathermap.org/current#fields_json these get provided in UTC, so this small patch applies the retrieved
gmtOffsetto them, before the UNIX epoch conversion.Also deals with some minor tab issues in the area.
Alternative: If the internal
gmtOffsetcould get exposed, in a getter or via making it a public or protected property, we could do such calculations in the watchface's code. It seemed cleaner to me to handle this within the library, as all exposed times otherwise seem to already be timezone adjusted, if I understood correctly.