Visual mode added #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual mode is now implemented with commands h, j, k, l, w, G, and y. Nothing for visual block mode has been added yet, just line and char.
Command j was off by one, causing the first selected line to be unselected and then reselected everytime there was a blank line. Also fixes visual line selection from inverting selection when at the end of dcument.
Command k would unselect and reselect the first line when at the first line. Command G did not move selection when attached to a number prefix. Command gg did not have visual mode implemented.
|
Patrick, please wait until Camila adds tests for spyder-vim before merging this one, so you can add tests for visual mode too. |
|
@ccordoba12 Can I merge this PR and then write those tests? |
|
Sure. |
|
Is it feasible to implement block selection (ctrl + v) in the visual mode? Or alternatively: Do you know of a way to modify a text block, which is not necessarily assosiated with the vim plugin? I found e.g. |
|
There's no way to do that in Spyder at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Added visual mode.
So far v and V work, so text can be selected by character or line.
ctrl + v has not been added, so block selection is not available.
Commands h, j, k, l, w, G, and y added to visual mode.
Note:
This PR is based off of #16 since most of visual mode's features are related to yanking text and pasting and the selection types must be tracked.