PR: Add utility functions that convert between ints and Qt Enums (compat.py) #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can see some failures on PySide2 that I'll address when I get to a machine that has a binary PySide2 available (I usually work on an arm64 mac). |
zjp
force-pushed
the
int_as_enum
branch
4 times, most recently
from
fef4bda
to
2dd8d02
Compare
|
Sorry it's taken me so long to update this PR. It looks like the last remaining failure is in PyQt5 on Python 3.7/Windows/Conda. The version in the runner is 5.9.2, but the last version available on Conda for that platform/tool combination is 5.15.7 so it would be possible to use almost the same version as the non-Conda version (5.15.10). Let me know your thoughts. |
for more information, see https://pre-commit.ci
|
I found a workaround. |
dalthviz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the functions I asked about in #356