Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkgin installer. #218

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add pkgin installer. #218

wants to merge 4 commits into from

Conversation

weakish
Copy link
Contributor

@weakish weakish commented Jul 10, 2016

pkgin is a binary package manager for pkgsrc on BSD, macOS,
Linux, SunOS, Minix and SmartOS/Illumos.


lib/sprinkle/installers/pkgin.rb | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 lib/sprinkle/installers/pkgin.rb

`pkgin` is a binary package manager for pkgsrc on BSD, macOS,
Linux, SunOS, Minix and SmartOS/Illumos.
@joshgoebel
Copy link
Contributor

Looks pretty good.

Can pkgin not install multiple packages at the same time by listing them out?

Should use sudo_cmd, not explicitly invoke sudo.

@weakish
Copy link
Contributor Author

weakish commented Jul 11, 2016

Can pkgin not install multiple packages at the same time by listing them out?

Yes.
Refactored to use auto_api.

Should use sudo_cmd

Fixed.

def pkgin(package, &block)
install Pkgin.new(self, package, &block)
end
end
verify_api do
def has_pkgin(package)
@commands << "pkgin list | egrep '^#{@package_name}-'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide this should be grep -e?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. New commits fixed this typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants