Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deprecated Usages of RemoteJWKSet and Integrate Custom Caching #16294

Closed

Conversation

kwondh5217
Copy link

Remove Deprecated Usage of RemoteJWKSet and Integrate Custom Caching

This PR addresses issue #16251 by replacing the usage of the deprecated RemoteJWKSet with a custom wrapper that integrates with Spring Security's caching mechanism.


Summary of Changes

Custom Wrapper for URL-Based JWK Source

  • Introduced SpringURLBasedJWKSource to wrap UrlBasedJWKSetSource.
  • Ensures compatibility with Spring's Cache abstraction for efficient JWK caching.

Removal of Deprecated API

  • Replaced all instances of RemoteJWKSet and JWKSetCache with the new custom wrapper and cache implementation.

Minimal Changes

  • Retains as much of the original logic as possible to ensure continuity and compatibility with existing code and functionality.

Testing

  • Verified that all existing tests continue to pass without modification.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2024
@kwondh5217 kwondh5217 closed this Dec 17, 2024
@kwondh5217 kwondh5217 deleted the remove-RemoteJWKSet branch December 17, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants