Avoid requesting an unnecessary attestation statement when creating a webauthn credential #16252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attestation option in PublicKeyCredentialCreationOptions is a parameter that controls whether to request attestation from the security key. However, Spring Security Passkeys currently doesn't implement attestation verification. Therefore, requesting attestation is unnecessary. Specifying `direct` to request attestation may trigger browsers to display additional privacy related dialog to users, so it is best to avoid specifying `direct` unnecessarily.
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: web
ynojima
added a commit
to ynojima/spring-security
that referenced
this pull request
Dec 12, 2024
…ion value Follow up for spring-projects#16252
rwinch
pushed a commit
that referenced
this pull request
Dec 12, 2024
…ion value Follow up for #16252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attestation option in PublicKeyCredentialCreationOptions is a parameter that controls whether to request attestation statement from the security key. Currently, Spring Security Passkeys requests attestation statement by specifiy
directvalue toattestationoption, but Spring Security Passkeys doesn't implement attestation statement verification[1]. Therefore, the requested attestation statement is not used at all.Specifying
directto request attestation may trigger browsers to display additional privacy related dialog to users, so it is best to avoid specifyingdirectunnecessarily.[1] Spring Security Passkeys uses WebAuthnManager.createNonStrictWebAuthnManager() to setup a
WebAuthnManagerinstance configured not to verify attestation statements.