Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore @AuthenticationPrincipal/@CurrentSecurityContext Interface Support #16245

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

kse-music
Copy link
Contributor

@kse-music kse-music commented Dec 9, 2024

Closes #16177

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 9, 2024
@jzheaux jzheaux changed the title Fallback annotation parameter find logic Restore @AuthenticationPrincipal Interface Support Dec 9, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Dec 9, 2024

Thanks, @kse-music! Will you please add unit tests that demonstrate that @AuthenticationPrincipal interface support is restored with these changes? Then, please also include the ticket that this closes, #16177.

With that, #16201 can focus on the related feature enhancement for SecurityAnnotationScanner.

@jzheaux jzheaux self-assigned this Dec 9, 2024
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 9, 2024
@jzheaux jzheaux added this to the 6.4.2 milestone Dec 9, 2024
@jzheaux jzheaux changed the title Restore @AuthenticationPrincipal Interface Support Restore @AuthenticationPrincipal/@CurrentSecurityContext Interface Support Dec 9, 2024
@jzheaux jzheaux merged commit 4cbaabb into spring-projects:main Dec 10, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Dec 10, 2024

Thanks, @kse-music! This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Issue when using @AuthenticationPrincipal on interfaces
3 participants