Use Documentation Tags for Maven and Gradle in Getting Started #16234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks for the PR, @harpreets789! I've left some feedback inline.
Also, will you please change the commit to use Issue gh-16228 instead of Closes gh-16228? That way the issue remains open for other documentation articles that need to introduce tabs.
jzheaux
added
in: docs
|
Thank you for your thorough review and valuable suggestions. I appreciate the directions you've provided and will make the necessary changes accordingly. |
harpreets789
force-pushed
the
gh-16228
branch
from
467dfdb to
6fe76f5
Compare
harpreets789
added a commit
to harpreets789/spring-security
that referenced
this pull request
Dec 10, 2024
…ation (spring-projects#16234) - Fixed minor formatting issues and addressed reviewer suggestions. - Issue spring-projectsgh-16228.
|
jzheaux
approved these changes
Dec 10, 2024
jzheaux
changed the title
|
Thanks, @harpreets789! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the separate XML and Gradle code snippets into joint tabs within the getting-spring-security.adoc file
Issue gh-16228