Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct OpenSAML 5.x Documentation #16195

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

harpreets789
Copy link
Contributor

  • Corrected a typo in the closing dependency XML tag.
  • Corrected typo in <artifactId> (opensaml-saml-imple -> opensaml-saml-impl).
  • Excluded all OpenSAML 4.x dependencies.
  • Removed redundant dependencies (opensaml-core-api and opensaml-core-impl) as they are transitively included in opensaml-saml-api and opensaml-saml-impl.

Closes gh-16191

- Fixed invalid XML tags in dependency examples.
- Corrected typo in `<artifactId>` ("opensaml-saml-imple" -> "opensaml-saml-impl").
- Excluded all OpenSAML 4.x dependencies.
- Removed redundant dependencies (`opensaml-core-api` and `opensaml-core-impl`) as they are transitively included in `opensaml-saml-api` and `opensaml-saml-impl`.

Closes spring-projectsgh-16191
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 1, 2024
@jzheaux jzheaux self-assigned this Dec 4, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 4, 2024
@jzheaux jzheaux added this to the 6.4.2 milestone Dec 4, 2024
@jzheaux jzheaux merged commit cc2506b into spring-projects:main Dec 4, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Dec 4, 2024

Good catch, @harpreets789! This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of OpenSAML 5.x is not correct
3 participants