Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay initialization AuthenticationProvider in Global Authentication #16050

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Delay initialization AuthenticationProvider in Global Authentication #16050

merged 1 commit into from
Nov 23, 2024
+10 −49

Conversation

kse-music
Copy link
Contributor

Related #16047

@kse-music kse-music mentioned this pull request Nov 8, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Nov 11, 2024

Given that we don't want to support the circular reference described in #16047, is there still value in making this change?

@kse-music
Copy link
Contributor Author

I think it may be useful, because this can avoid the instantiation of AuthenticationProvider caused by the GlobalAuthenticationConfigurer configuration when there are multiple AuthenticationProvider beans in the context. Since there are multiple AuthenticationProvider beans, GlobalAuthenticationConfigurer will not set the AuthenticationProvider, so there is no need to instantiate it here early.

jzheaux
jzheaux requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kse-music! I've left some feedback inline.

...tion/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java Outdated Show resolved Hide resolved
@kse-music kse-music mentioned this pull request Nov 21, 2024
Open
@kse-music
Copy link
Contributor Author

@jzheaux I did it as you expected, and also I create another PR #16144 doing the same thing

@jzheaux jzheaux merged commit e8ba039 into spring-projects:6.3.x Nov 23, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Nov 23, 2024

Thanks, @kse-music! This is now merged into 6.3.x and main

@jzheaux jzheaux self-assigned this Nov 23, 2024
@jzheaux jzheaux added in: config An issue in spring-security-config type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 23, 2024
@jzheaux jzheaux added this to the 6.3.6 milestone Nov 23, 2024
@jzheaux jzheaux mentioned this pull request Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
None yet
Milestone
6.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@kse-music @jzheaux @spring-projects-issues