Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assertions #15937

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix assertions #15937

merged 2 commits into from
Nov 13, 2024

Conversation

dcolazin
Copy link
Contributor

No description provided.

@pivotal-cla
Copy link

@dcolazin Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@dcolazin Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 17, 2024
@sjohnr sjohnr self-assigned this Oct 17, 2024
@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 17, 2024
sjohnr
sjohnr requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dcolazin. Thanks for the PR! Could you please adjust the assertions as in the suggestion below?

...ose/src/test/java/org/springframework/security/oauth2/jwt/NimbusReactiveJwtDecoderTests.java Outdated Show resolved Hide resolved
@sjohnr sjohnr added the status: waiting-for-feedback We need additional information before we can continue label Oct 24, 2024
@sjohnr sjohnr added type: task A general task and removed status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement labels Nov 13, 2024
@sjohnr sjohnr added this to the 6.4.0 milestone Nov 13, 2024
@sjohnr sjohnr merged commit ca1f891 into spring-projects:main Nov 13, 2024
6 checks passed
@ngocnhan-tran1996 ngocnhan-tran1996 mentioned this pull request Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjohnr sjohnr sjohnr requested changes

Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: task A general task
Projects
Spring Security Team
Status: Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dcolazin @pivotal-cla @sjohnr @spring-projects-issues