Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @FunctionalInterface to AuthenticationManager #15441

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

pongdangx2
Copy link
Contributor

@pongdangx2 pongdangx2 commented Jul 18, 2024

Add @FunctionalInterface to AuthenticationManager.

AuthenticationManager is being implemented by using lambda. Therefore, It would be clear not to add more abstract functions, if @FunctionalInterface Annotation is added.

cf. #15379

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 18, 2024
@pongdangx2
Copy link
Contributor Author

@jzheaux
HI, Thanks for your instruction. I just discarded my commits and make it again.

@jzheaux jzheaux self-assigned this Jul 19, 2024
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 19, 2024
@jzheaux jzheaux added this to the 6.4.0-M2 milestone Jul 19, 2024
@jzheaux jzheaux merged commit 4036e91 into spring-projects:main Jul 19, 2024
4 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jul 19, 2024

Thanks for the PR, @pongdangx2! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants