Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ServerAuthorizationRequestRepository to remove unnecessary generic #15435

Closed
wants to merge 1 commit into from
Closed

Refactor ServerAuthorizationRequestRepository to remove unnecessary generic #15435

wants to merge 1 commit into from

Conversation

baezzys
Copy link
Contributor

@baezzys baezzys commented Jul 17, 2024

Closes gh-15426

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 17, 2024
@sjohnr
Copy link
Member

sjohnr commented Jul 17, 2024

Hi @baezzys, thanks for your interest in contributing!

However, as gh-15426 won't be worked on right now (see this comment), I think it's best to hold off on this. I'm going to close this PR for now as I don't want it to sit around for an extended period of time collecting dust. However, feel free to keep the branch around for reference. I will update gh-15426 when it's time to work on that issue for SS7. Let me know if you have any questions about this.

@sjohnr sjohnr closed this Jul 17, 2024
@sjohnr sjohnr self-assigned this Jul 17, 2024
@sjohnr sjohnr added type: enhancement A general enhancement status: declined A suggestion or change that we don't feel we should currently apply in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 17, 2024
@baezzys
Copy link
Contributor Author

baezzys commented Jul 17, 2024

Hi @sjohnr, I understand the situation. It's perfectly fine to close this PR. I'm ready to work on it again whenever the issue comes up. Please feel free to reach out if you need any assistance in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing generics from AuthorizationRequestRepository
3 participants