Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Backchannel Logout should allow logout tokens having typ header of logout+jwt #15277

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

OLibutzki
Copy link

@OLibutzki OLibutzki commented Jun 19, 2024

Backport of the solution for #15003 to 6.2.x .

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 19, 2024
@jzheaux jzheaux self-assigned this Jun 24, 2024
@jzheaux jzheaux added type: backport An issue that is a backport of another issue to a maintenance branch in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2024
@jzheaux jzheaux added this to the 6.2.6 milestone Jun 24, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jun 24, 2024

Hi, @OLibutzki. It looks like the build is failing. Are you able to repair it? It looks like the commit you backported is using a method that doesn't exist in 6.2.x.

@OLibutzki
Copy link
Author

Hi @jzheaux,

obviously, I have been too optimistic by cherry-picking the commit. I fixed the error.

OidcIdTokenDecoderFactory.createDefaultClaimTypeConverter() has been introduced in 6.3, so when merging to 6.3.x this new method should be used.

@OLibutzki
Copy link
Author

OLibutzki commented Jul 3, 2024

@jzheaux anything I can do to push this issue/PR ahead? For our application it's crucial to use Keycloak 25 and therefore it would help us a lot to ensure Spring Security's compatibility.

@jzheaux jzheaux merged commit 7422a11 into spring-projects:6.2.x Jul 12, 2024
4 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jul 12, 2024

Thanks, @OLibutzki, this is now merged into 6.2.x and forward ported to 6.3.x

@jzheaux jzheaux changed the title Allow logout+jwt JWT type OIDC Backchannel Logout should allow logout tokens having typ header of logout+jwt Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants