Spring Security annotations on subclasses support intercepting parent class methods. #14479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kse-music
changed the title
kse-music
changed the title
Previously, the `decode` method threw a `JwtException` directly when encountering an unsupported algorithm or any exception during parsing. This commit introduces a more robust error handling mechanism. Now, instead of throwing exceptions directly, it returns a `Mono.error()` with a `BadJwtException` containing detailed error information. This approach provides more flexibility and allows the caller to handle errors in a more granular way, by being able to use project reactors onError functionality. Closes spring-projectsgh-14467
Closes spring-projectsgh-14493 Signed-off-by: ahmd-nabil <[email protected]>
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action) from 1.24.0 to 1.25.0. - [Release notes](https://github.com/slackapi/slack-github-action/releases) - [Commits](slackapi/slack-github-action@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: slackapi/slack-github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [gradle/gradle-build-action](https://github.com/gradle/gradle-build-action) from 2 to 3. - [Release notes](https://github.com/gradle/gradle-build-action/releases) - [Commits](gradle/gradle-build-action@v2...v3) --- updated-dependencies: - dependency-name: gradle/gradle-build-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Closes spring-projectsgh-14186 Signed-off-by: ahmd-nabil <[email protected]>
Signed-off-by: ahmd-nabil <[email protected]>
- Add Tests - Add Reactive Support Issue spring-projectsgh-14186
jzheaux
added
in: core
there is no word like 'byusing'. I fixed 'byusing' to 'by using'.
lambda expression typo. I changed '(session) - session' to '(session) -> session'
jzheaux
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Thanks, @kse-music! This is looking good; I've left some feedback inline.
Also, when you submit the requested changes, will you please squash your commits and have the commit message contain a title and the ticket like so:
Have Method Security Start at Target Class
Closes gh-13783
Feel free to have a different title, the above is just the requested format.
| } | ||
|
|
||
| @RolesAllowed("USER") | ||
| public static class RolesAllowedClass extends SecuredAuthorizationManagerTests.ParentClass { |
There was a problem hiding this comment.
Please copy the definition for ParentClass in this class. That way, the test classes don't refer to each other.
| } | ||
|
|
||
| @PostAuthorize("hasRole('USER')") | ||
| public static class PostAuthorizeClass extends SecuredAuthorizationManagerTests.ParentClass { |
There was a problem hiding this comment.
Please copy the definition for ParentClass in this class. That way, the test classes don't refer to each other.
Please also do this with any other references to the ParentClass defined in another test class.
|
Also, I'd recommend rebasing so that you don't need to the two extra formatting changes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-13783