Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step names must be unique #3757 #4544

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

FBibonne
Copy link

@FBibonne FBibonne commented Feb 5, 2024

@FBibonne
Copy link
Author

FBibonne commented Feb 5, 2024

Solves #3757

@FBibonne
Copy link
Author

FBibonne commented Feb 5, 2024

WIP because 5 tests still fail

@FBibonne
Copy link
Author

FBibonne commented Feb 6, 2024

All tests passed.

  • pom is updated to have a have a version of slf4j-api corresponding to simple-slf4j
  • unicity of names is checked when starting the job , just before calling listeners because step names may be known only in JobScope
  • in FlowJob.findStepsThrowingIfNameNotUnique, I suggest to remove the else block when state is instance of StepHolder : it is never executed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants