Prefix for JobScope changed to scopedTarget #4353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen xml and java-config is mixed.
|
Thank you for your PR!
Can you please elaborate on the problem? Is this similar to #3938? |
fmbenhassine
added
the
status: waiting-for-reporter
|
yes it is similar, I used for the PR the same solution. In this #3938 farnetto also suggested it. I hope it helps you to fix this issue. |
|
OK thank you for your feedback. I am just trying to understand the problem this PR is trying to solve to document it in the change log. I will try the test you added in this PR without the fix to see the issue. |
fmbenhassine
added
status: feedback-provided
|
Yes, with the Test you will see, that the Framework builds a second Proxy around the JobScoped-Bean, with other interfaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with JobScope when xml and java-config is mixed.
I could solve it, with changing the TARGET_NAME_PREFIX in the class JobScope.
I also wrote a JUnit-Test for this fix.