Initialize useUserAccessToken to false. #6072
Closed
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the effort to remove deprecated methods from TaskConfigurationProperties: spring-cloud@b27f0c2 We introduced a NPE when DefaultTaskExecutionService.handleAccessToken tried to use useUserAccessToken. The original code would use TaskServiceUtils to return a false if it was null. Add Tests Signed-off-by: Glenn Renfro <[email protected]>
onobc
reviewed
Nov 14, 2024
...ework/cloud/dataflow/server/service/impl/ComposedTaskRunnerConfigurationPropertiesTests.java
Show resolved
Hide resolved
onobc
reviewed
Nov 14, 2024
...ework/cloud/dataflow/server/service/impl/ComposedTaskRunnerConfigurationPropertiesTests.java
Show resolved
Hide resolved
|
Implemented the requested changes. Thanks @onobc for the review!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the effort to remove deprecated methods from TaskConfigurationProperties with this commit, we introduced a NPE when DefaultTaskExecutionService.handleAccessToken tried to use useUserAccessToken. The original code would use TaskServiceUtils to return a false if it was null.
This behavior was a shim to maintain backwards compatibility which is no longer needed.
So the solution is to set the default for this field to false.