Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Prometheus RSocket Proxy 2.0.0-M2 #6070

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update to Prometheus RSocket Proxy 2.0.0-M2 #6070

merged 1 commit into from
Nov 14, 2024

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Nov 13, 2024

This commit updates the Prometheus Rsocket Proxy dependency and Docker images used in the installers to 2.0.0-M2.

See #6069

@onobc onobc added the review/at-least-one Only one reviewer is required to merge this PR. label Nov 13, 2024
@onobc onobc requested review from corneil and cppwfs November 13, 2024 18:01
cppwfs
cppwfs requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@cppwfs cppwfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Only one nitpick:
Do we want to update the configuration-options.adoc configuration-options-scdf.feature.monitoring.prometheusRsocketProxy.image.tag to 2.0.0-M2 from 1.0.0

@onobc
Copy link
Contributor Author

onobc commented Nov 13, 2024

Looks great! Only one nitpick: Do we want to update the configuration-options.adoc configuration-options-scdf.feature.monitoring.prometheusRsocketProxy.image.tag to 2.0.0-M2 from 1.0.0

Thanks @cppwfs !
I would not call that a nitpick but rather a great find since I missed it. Updated.

That being said, is this doc manually managed (i.e. not auto-generated)?

  1. I did not even know it existed
  2. I wonder what else is out of date?

@onobc onobc requested a review from cppwfs November 13, 2024 19:38
cppwfs
cppwfs approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@cppwfs cppwfs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Merge when you have finished the tests.
Thanks for working on this!

This is not a generated file according to the history.
But looks like we need to add it our release document for update or actually automate the generation of it.

@onobc
Update to Prometheus Rsocket Proxy 2.0.0-M2
b4f9204 
This commit updates the Prometheus Rsocket Proxy dependency and Docker images
used in the installers to 2.0.0-M2.

See spring-cloud#6069

Signed-off-by: Chris Bono <[email protected]>
@onobc onobc force-pushed the update-prometheus-rsocket-proxy-M2 branch from b862f7d to b4f9204 Compare November 13, 2024 22:10
@onobc onobc merged commit 464868b into spring-cloud:main Nov 14, 2024
3 checks passed
@onobc onobc deleted the update-prometheus-rsocket-proxy-M2 branch November 14, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppwfs cppwfs cppwfs approved these changes

@corneil corneil Awaiting requested review from corneil

Assignees
No one assigned
Labels
review/at-least-one Only one reviewer is required to merge this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onobc @cppwfs