This repository has been archived by the owner on Jan 17, 2019. It is now read-only.
Don’t use XCTAssertEqual for NSIndexPath equivalence. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spotify/objc-dev |
Generated by 🚫 danger |
Current coverage is 93.48% (diff: 100%)@@ master #268 diff @@
==========================================
Files 72 72
Lines 5019 5019
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4689 4692 +3
+ Misses 330 327 -3
Partials 0 0
|
|
👍 |
dalef84
approved these changes
Jan 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we decide the best way to assert for object equivalence over at #259, we should fix the cases that are causing tests to fail on 32-bit systems (i.e. the
NSIndexPathcase).For info, using instance equality (i.e.
==) on 2 "equivalent" instances will work on 64 bit architectures (with tagged pointers) but not on 32 bit architectures.