- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Android Gradle Plugin 3.5.3, 3.6.3, 4.0.0 #252
Support Android Gradle Plugin 3.5.3, 3.6.3, 4.0.0 #252
Conversation
aa587bf
to
c531524
Compare
@KengoTODA My suggestion regarding the Gradle versions is to bump 5.6 to 5.6.4 for CI, as any project that's still on 5.6 should be updating to 5.6.4 anyway. If that's not agreeable, the functional test would have to be modified to be skipped if Gradle 5.6 is used. |
c531524
to
a47487a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! It'll help us to support Android projects.
I wrote some feedback, could you check?
src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsTaskFactory.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/github/spotbugs/snom/internal/SpotBugsTaskFactory.java
Outdated
Show resolved
Hide resolved
Hi @davidburstromspotify, are you gonna work on this? |
遅くなってごめんね。I started doing the changes, plus ensuring that AGP 4.0.0 is also supported. |
The misc.xml is updated depending on which version of IntelliJ is in use. The compiler.xml is updated based on local settings. The .iml files gets generated by IntelliJ while importing a Gradle project.
By looping over the variants, it is possible to associate each of them with a given SpotBugs task. Each variant has a compilation task that can be hooked up.
a47487a
to
10073fb
Compare
10073fb
to
16200b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for your contribution! It should help android users to run SpotBugs. 👏
🎉 This PR is included in version 4.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fixes #233 and #90