Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android Gradle Plugin 3.5.3, 3.6.3, 4.0.0 #252

Merged
merged 7 commits into from
Jun 6, 2020

Conversation

davidburstromspotify
Copy link
Contributor

@davidburstromspotify davidburstromspotify commented May 14, 2020

Fixes #233 and #90

@davidburstromspotify davidburstromspotify force-pushed the master-agp-3.6 branch 3 times, most recently from aa587bf to c531524 Compare May 14, 2020 15:18
@davidburstromspotify
Copy link
Contributor Author

@KengoTODA My suggestion regarding the Gradle versions is to bump 5.6 to 5.6.4 for CI, as any project that's still on 5.6 should be updating to 5.6.4 anyway. If that's not agreeable, the functional test would have to be modified to be skipped if Gradle 5.6 is used.

Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! It'll help us to support Android projects.
I wrote some feedback, could you check?

@KengoTODA KengoTODA changed the title Support Android Gradle Plugin 3.5.3 and 3.6.3 feat: Support Android Gradle Plugin 3.5.3 and 3.6.3 May 26, 2020
@KengoTODA KengoTODA changed the title feat: Support Android Gradle Plugin 3.5.3 and 3.6.3 Support Android Gradle Plugin 3.5.3 and 3.6.3 May 26, 2020
@otiai10
Copy link

otiai10 commented Jun 2, 2020

Hi @davidburstromspotify, are you gonna work on this?

@davidburstromspotify
Copy link
Contributor Author

遅くなってごめんね。I started doing the changes, plus ensuring that AGP 4.0.0 is also supported.

The misc.xml is updated depending on which version of
IntelliJ is in use.

The compiler.xml is updated based on local settings.

The .iml files gets generated by IntelliJ while importing a
Gradle project.
By looping over the variants, it is possible to associate
each of them with a given SpotBugs task. Each
variant has a compilation task that can be hooked up.
@davidburstromspotify davidburstromspotify changed the title Support Android Gradle Plugin 3.5.3 and 3.6.3 Support Android Gradle Plugin 3.5.3, 3.6.3, 4.0.0 Jun 3, 2020
Copy link
Member

@KengoTODA KengoTODA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for your contribution! It should help android users to run SpotBugs. 👏

@KengoTODA KengoTODA merged commit b6a6d92 into spotbugs:master Jun 6, 2020
@github-actions
Copy link

github-actions bot commented Jun 6, 2020

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants