修改使用alias时的几个bug #98
Open
修改使用alias时的几个bug #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
使用alias时候不会递归的提取依赖
使用alias只提取一层依赖，没有递归的提取相关子依赖
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.id = iduri.absolute(alias, id) 这个代码id是相对路径时候会生成绝对路径的，但是这个id也可能是另外一个alias，所以加个iduri.parseAlias(options, id)
2.parseModuleDependencies这个函数是解析不是相对路径的情况，但是这个函数里面没有递归的提取子依赖